⚡ Bolt: [performance improvement] Fix N+1 query in injectPerUserOAuthTokens hook - #164
Conversation
Refactored the `injectPerUserOAuthTokens` hook to extract all `mcp_server_id`s from the results upfront and issue a single batched database lookup using the new `getTokensForServers` method in `UserMCPOAuthTokenRepository`. This avoids N+1 queries when resolving OAuth tokens over multiple servers.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Introduced a batched method
getTokensForServersto query OAuth tokens for multiple server IDs at once. Updated theinjectPerUserOAuthTokenshook to pre-fetch all server tokens synchronously before resolving each individual server's OAuth token.🎯 Why: Iterating over paginated or list requests and awaiting
userTokenRepo.getTokenfor each item generates N+1 queries, significantly increasing database latency for responses containing multiple MCP servers.📊 Impact: Reduces database queries from O(N) to O(1) for OAuth token resolution when listing servers.
🔬 Measurement: Run the test suite and verify test stability (
pnpm test). Themcp-serverslist endpoint performance can be measured using any network tracer.PR created automatically by Jules for task 17916299599179153157 started by @Donach